Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix password placeholders in credential summary #797

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Fix password placeholders in credential summary #797

merged 1 commit into from
Mar 24, 2017

Conversation

mzazrivec
Copy link
Contributor

Fixes:

  • password placeholder to be consistent with the rest of our UI
  • display password placeholder only if it's actually set

Before:
pass-placeholder-before

After:
pass-placeholder-after

@mzazrivec mzazrivec force-pushed the fix_password_placeholders_in_credential_summary branch from 03e39a9 to f31d4ac Compare March 24, 2017 11:47
@miq-bot
Copy link
Member

miq-bot commented Mar 24, 2017

Checked commit mzazrivec@f31d4ac with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@h-kataria
Copy link
Contributor

Looks good.

@h-kataria h-kataria added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 24, 2017
@h-kataria h-kataria merged commit 3c41278 into ManageIQ:master Mar 24, 2017
@mzazrivec mzazrivec deleted the fix_password_placeholders_in_credential_summary branch February 22, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
automation/ansible bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzazrivec @miq-bot @h-kataria