Removed all dialog related settings from form & summary screen #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit h-kataria@dc38495 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/layouts/angular/_ansible_form_options_angular.html.haml |
|
I think code climate errors can be ignored in this code removal PR. |
|
@syncrou Please review |
|
@h-kataria - I tested this and it worked for me. I was wondering about the rubocop error for Other than that question - it looks ok and works for me. |
|
@syncrou not addressing those rubocop issues in this PR, i didn't make any other changes in this PR other than removing code that is not needed any more. |
|
@martinpovolny @himdel @chessbyte please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/142347417
@gmcculloug @bzwei please review
before:
after:
