Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Configured Systems out of Ansible Tower Explorer #7640

Merged
merged 7 commits into from
Mar 2, 2021

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Feb 23, 2021

De-explorized Configured Systems, Added new second level "Configured Systems" under Automation/Ansible Tower

Dependent core PR
Cross repo PR

before
Screen Shot 2021-02-22 at 1 44 42 PM
Screen Shot 2021-02-22 at 1 44 27 PM
Screen Shot 2021-02-22 at 1 44 01 PM

after
Screen Shot 2021-02-23 at 1 15 05 PM

Screen Shot 2021-02-23 at 1 09 38 PM

@h-kataria h-kataria changed the title Moved Configured Systems out of Ansible Tower Explorer [WIP] - Moved Configured Systems out of Ansible Tower Explorer Feb 23, 2021
@h-kataria h-kataria added the wip label Feb 23, 2021
@h-kataria h-kataria changed the title [WIP] - Moved Configured Systems out of Ansible Tower Explorer Moved Configured Systems out of Ansible Tower Explorer Feb 23, 2021
@h-kataria h-kataria removed the wip label Feb 23, 2021
@h-kataria
Copy link
Contributor Author

@kavyanekkalapu can you please test in UI.

@h-kataria
Copy link
Contributor Author

@miq-bot cross_repo_tests manageiq-api, manageiq-ui-classic including manageiq#21076

@miq-bot
Copy link
Member

miq-bot commented Feb 24, 2021

This pull request is not mergeable. Please rebase and repush.

@kavyanekkalapu
Copy link
Member

@h-kataria I tested functionality , looks good to me, i couldn't find any issues.

@gtanzillo gtanzillo closed this Mar 1, 2021
@gtanzillo gtanzillo reopened this Mar 1, 2021
@h-kataria h-kataria closed this Mar 2, 2021
@h-kataria h-kataria reopened this Mar 2, 2021
De-explorized Configured Systems, Added new second level "Configured Systems" under Automation/Ansible Tower
Removed 'Configured System' Accordion from Ansible Tower explorer, will delete rest of the configured system related code with de-explorization of Ansible Tower explorer.
@h-kataria h-kataria force-pushed the configured_systems branch from 72adc03 to 5db82c9 Compare March 2, 2021 17:37
reverted cloud_volume route changes from f951040
@miq-bot
Copy link
Member

miq-bot commented Mar 2, 2021

Checked commits h-kataria/manageiq-ui-classic@f951040~...77e8660 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
15 files checked, 21 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

app/controllers/automation_manager_configured_system_controller.rb

app/helpers/application_helper/toolbar/automation_manager_configured_system_center.rb

app/helpers/application_helper/toolbar/automation_manager_configured_systems_center.rb

app/helpers/automation_manager_configured_system_helper.rb

  • ❗ - Line 14, Col 16 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
  • ❗ - Line 18, Col 45 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
  • ❗ - Line 22, Col 43 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
  • ❗ - Line 26, Col 44 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
  • ❗ - Line 31, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
  • ❗ - Line 32, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
  • ❗ - Line 37, Col 37 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
  • ❗ - Line 44, Col 1 - Layout/EmptyComment - Source code comment is empty.

config/routes.rb

spec/controllers/automation_manager_controller_spec.rb

@gtanzillo gtanzillo merged commit 2ac2a40 into ManageIQ:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants