Hiding Network Credentials on retirement tab on summary screen #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
hide_network_cred_on_retirement_tab
branch
from
ce21780 to
e1b49fc
Compare
|
Checked commit h-kataria@e1b49fc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/catalog/_sandt_tree_show.html.haml |
|
Looks good 👍 |
|
@mzazrivec please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/141970189
@gmcculloug realised i didnt remove
Network Credentialfrom Retirement tab on catalog Item summary, this PR can be merged after #762 is mergedbefore
after
