Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dead routes related to EMS storage #7611

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

skateman
Copy link
Member

@skateman skateman commented Feb 1, 2021

Followup on #7607 these routes are not accessible from the UI

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@miq-bot
Copy link
Member

miq-bot commented Feb 1, 2021

Checked commit skateman@5f6c22f with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

Sorry, something went wrong.

@himdel
Copy link
Contributor

himdel commented Feb 3, 2021

Aaah...

ems_storage - not exposed in menu but used for shared storage actions, makes sense to remove
ems_block_storage - unaffected, still has new and edit
ems_object_storage - removing new&edit, as there are no StorageManagers supporting ems_storage_new

There may still be toolbars leading to these routes, but I suppose that's a separate untangling. (ems_storage_center toolbar has an edit button, which should only work for block storage storagemanagers now, but is missing that logic)

@himdel himdel merged commit 4fc49bc into ManageIQ:master Feb 3, 2021
@skateman skateman deleted the drop-storage-routes branch February 4, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants