Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for editing a playbook service template #761

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Mar 21, 2017

Enable the Save button on the Edit Playbook catalog item only when there is a change in the model.
Get the cloud credential type from the cloud credential id if one was saved.

https://bugzilla.redhat.com/show_bug.cgi?id=1437541

@lgalis
Copy link
Contributor Author

lgalis commented Mar 21, 2017

@miq-bot add_label wip, automation/ansible_tower, bug

@miq-bot
Copy link
Member

miq-bot commented Mar 21, 2017

@lgalis Cannot apply the following label because they are not recognized: automation/ansible_tower

@lgalis lgalis force-pushed the update_playbook_service_template_save_button branch 10 times, most recently from d074607 to 450c3e4 Compare March 27, 2017 19:03
@lgalis lgalis changed the title [WIP] Fixes for editing a playbook service template Fixes for editing a playbook service template Mar 27, 2017
@miq-bot miq-bot removed the wip label Mar 27, 2017
@lgalis lgalis force-pushed the update_playbook_service_template_save_button branch 3 times, most recently from 622eb45 to 6dca771 Compare March 27, 2017 20:06
@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2017

@lgalis unrecognized command 'assigne', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@lgalis
Copy link
Contributor Author

lgalis commented Mar 27, 2017

@miq-bot assign @h-kataria

@lgalis lgalis changed the title Fixes for editing a playbook service template [WIP] Fixes for editing a playbook service template Mar 27, 2017
@miq-bot miq-bot added the wip label Mar 27, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2017

This pull request is not mergeable. Please rebase and repush.

@lgalis lgalis force-pushed the update_playbook_service_template_save_button branch from 6dca771 to a0467a5 Compare March 27, 2017 22:22
@lgalis lgalis force-pushed the update_playbook_service_template_save_button branch from d3df71e to 53f5e16 Compare March 28, 2017 14:49
@lgalis lgalis changed the title [WIP] Fixes for editing a playbook service template Fixes for editing a playbook service template Mar 28, 2017
@miq-bot miq-bot added the wip label Mar 30, 2017
@lgalis lgalis force-pushed the update_playbook_service_template_save_button branch 2 times, most recently from 498e740 to dbc4f7c Compare March 31, 2017 14:21
@lgalis lgalis force-pushed the update_playbook_service_template_save_button branch 4 times, most recently from bf59777 to d2ce7ee Compare March 31, 2017 16:03
@lgalis lgalis force-pushed the update_playbook_service_template_save_button branch from d2ce7ee to 871f2af Compare March 31, 2017 16:19
@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2017

Checked commits lgalis/manageiq-ui-classic@f7e60ce~...871f2af with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🍪

@lgalis lgalis changed the title [WIP] Fixes for editing a playbook service template Fixes for editing a playbook service template Mar 31, 2017
@miq-bot miq-bot removed the wip label Mar 31, 2017
@h-kataria
Copy link
Contributor

verified in UI. Looks good.

@h-kataria h-kataria added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 31, 2017
@h-kataria h-kataria merged commit b3fba79 into ManageIQ:master Mar 31, 2017
@lgalis lgalis deleted the update_playbook_service_template_save_button branch March 31, 2017 18:25
simaishi pushed a commit that referenced this pull request Mar 31, 2017
…save_button

Fixes for editing a playbook service template
(cherry picked from commit b3fba79)

https://bugzilla.redhat.com/show_bug.cgi?id=1438091
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 72088546a212be2bf486641a9c5b2b70a0f6e073
Author: Harpreet Kataria <[email protected]>
Date:   Fri Mar 31 13:18:32 2017 -0400

    Merge pull request #761 from lgalis/update_playbook_service_template_save_button
    
    Fixes for editing a playbook service template
    (cherry picked from commit b3fba79edd6949922e5df7d110c2723cf777a177)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1438091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants