Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead render partial #7609

Merged
merged 10 commits into from
Jan 28, 2021
Merged

Dead render partial #7609

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
aa5fbff
prov_wf: remove dead prov_host_dialog reference
himdel Jan 28, 2021
9ca9010
alert_details: remove dead alert_assign reference
himdel Jan 28, 2021
eac147d
Remove dead app/views/dashboard/_dropdownbar.html.haml
himdel Jan 28, 2021
324370c
rates_tabs: fix edit vs form partial reference
himdel Jan 28, 2021
e8bb369
miq_template: remove dead layouts/drift reference
himdel Jan 28, 2021
3dd3484
policy explorer: remove dead _profile_list reference
himdel Jan 28, 2021
7242fff
Drop dead service/explorer.js partial
himdel Jan 28, 2021
0676634
configuration/show - drop dead ui_2 reference
himdel Jan 28, 2021
557b0fa
miq_template/show: remove dead vm_common/provision reference
himdel Jan 28, 2021
ab50019
_rates_tabs - remove unused partial
himdel Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/chargeback_rate/_rates_tabs.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
- if x_node == "root"
= render :partial => "rates_list"
- elsif @edit && @edit[:new] && ((params[:pressed] && params[:pressed] != "chargeback_rates_delete") || params[:button] == "reset")
= render :partial => "edit"
= render :partial => "form"
Copy link
Contributor

@h-kataria h-kataria Jan 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@himdel this view can be deleted, it is not being used

Copy link
Contributor Author

@himdel himdel Jan 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, perfect, I'll remove it.

Do you mean rates_tabs or the rates form as well?

EDIT: Oh, the form is still rendered through the edit action/template. So just rates tabs :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated :)

- elsif %w(Compute Storage).include?(x_node.split('-').last)
= render :partial => 'layouts/x_gtl', :locals => {:action_url => "cb_rates_list"}
- else
Expand Down
2 changes: 0 additions & 2 deletions app/views/configuration/show.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
- case @tabform
- when 'ui_1'
= render :partial => 'ui_1'
- when 'ui_2'
= render :partial => 'ui_2'
- when 'ui_3'
= render :partial => 'ui_3'
- when 'ui_4'
Expand Down
3 changes: 0 additions & 3 deletions app/views/dashboard/_dropdownbar.html.haml
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions app/views/miq_alert/_alert_details.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
- url = url_for_only_path(:action => 'alert_field_changed', :id => (@alert.id || 'new'))
- observe = {:url => url}.to_json
#alert_details_div
- if @assign
= render :partial => 'alert_assign'
- elsif @alert
- if @alert
#alert_info_div
= render :partial => "layouts/flash_msg"
%h3= _('Info')
Expand Down
6 changes: 1 addition & 5 deletions app/views/miq_policy/explorer.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
- case @nodetype
- when "root"
- case x_active_tree
- when :policy_profile_tree
= render :partial => "profile_list"
- when :policy_tree
= render :partial => "policy_folders"
- when :event_tree
Expand All @@ -22,9 +20,7 @@
- when "pp"
= render :partial => "profile_details"
- when "xx"
- if @profiles
= render :partial => "profile_list"
- elsif @policies || (@view && @sb[:tree_typ] == "policies")
- if @policies || (@view && @sb[:tree_typ] == "policies")
= render :partial => "policy_list"
- elsif @conditions
= render :partial => "condition_list"
Expand Down
2 changes: 0 additions & 2 deletions app/views/miq_request/_prov_wf.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
= render :partial => "/shared/views/prov_dialog", :locals => partial_locals
- elsif wf.kind_of?(VmMigrateWorkflow)
= render :partial => "/miq_request/prov_vm_migrate_dialog", :locals => partial_locals
- else
= render :partial => "/miq_request/prov_host_dialog", :locals => partial_locals

:javascript
miq_tabs_init('#prov_tabs', '/miq_request/prov_field_changed', {edit_mode: 'true'});
Expand Down
4 changes: 0 additions & 4 deletions app/views/miq_template/show.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
= render :partial => "vm_common/right_size"
- elsif @reconfigure
= render :partial => "vm_common/reconfigure"
- elsif request.parameters[:action] == "provision"
= render :partial => "vm_common/provision"
- else
- case @showtype
- when "details"
Expand All @@ -17,8 +15,6 @@
= render :partial => "layouts/compare"
- when "drift_history"
= render :partial => "layouts/drift_history"
- when "drift"
= render :partial => "layouts/drift"
- when "item"
= render :partial => "layouts/item"
- when "performance"
Expand Down
17 changes: 0 additions & 17 deletions app/views/service/_explorer.js.haml
View file
Open in desktop

This file was deleted.