Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets default security_protocol for middleware #758

Merged

Conversation

josejulio
Copy link
Member

Sets the default security protocol for middleware.

I missed to push this commit to #460.
This is used when editing an old middleware endpoint which didn't have any Security Protocol

It will turn this:
dsp_before

Into this:
dsp_after

@miq-bot add_label middleware euwe/no enhancement.

@AparnaKarve could you please review?

@miq-bot
Copy link
Member

miq-bot commented Mar 21, 2017

@josejulio Cannot apply the following label because they are not recognized: middleware euwe/no enhancement.

@josejulio
Copy link
Member Author

@miq-bot add_label middleware, euwe/no, enhancement.

@miq-bot
Copy link
Member

miq-bot commented Mar 21, 2017

@josejulio Cannot apply the following label because they are not recognized: enhancement.

@josejulio josejulio force-pushed the hawkular/set_default_security_protocol branch from 92c016c to c9d5d87 Compare March 21, 2017 18:55
@miq-bot
Copy link
Member

miq-bot commented Mar 21, 2017

Checked commit josejulio@c9d5d87 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@AparnaKarve
Copy link
Contributor

@josejulio Thanks for the screenshots.
LGTM !!

@josejulio
Copy link
Member Author

@martinpovolny could you please review and merge?

@mzazrivec mzazrivec added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 23, 2017
@mzazrivec mzazrivec merged commit a9fa2c4 into ManageIQ:master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants