Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Flavor form fully API driven and functional #7462

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

skateman
Copy link
Member

@skateman skateman commented Oct 28, 2020

Even though the flavor form has been converted to react, it was still using controller routes from the ui-classic repo to feed some data into its dropdowns. As these endpoints have matching endpoints in the API, the form has been be converted to use them instead.

Found a bug in DDF that can be triggered from here: data-driven-forms/react-forms#866

Depends on:
ManageIQ/manageiq#20747
ManageIQ/manageiq-providers-openstack#659

@skateman skateman mentioned this pull request Oct 28, 2020
13 tasks
@miq-bot miq-bot added the wip label Oct 28, 2020
@skateman skateman force-pushed the flavor-form-api branch 2 times, most recently from 85431b6 to 9251908 Compare October 29, 2020 09:54
@skateman skateman changed the title [WIP] Make the Flavor form fully API driven and functional Make the Flavor form fully API driven and functional Oct 29, 2020
@miq-bot miq-bot removed the wip label Oct 29, 2020
@miq-bot
Copy link
Member

miq-bot commented Oct 29, 2020

Checked commit skateman@4db7336 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@h-kataria h-kataria merged commit d0cd204 into ManageIQ:master Oct 30, 2020
@skateman skateman deleted the flavor-form-api branch October 30, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants