Fix all users of CredentialsController to provide vm-scope #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: Looks good :) |
AparnaKarve
reviewed
Mar 17, 2017
| @@ -4,7 +4,7 @@ | |||
| - vm_scope ||= false | |||
| - main_scope = vm_scope ? "$parent.vm" : "$parent" | |||
|
|
|||
| %div{"ng-controller" => "CredentialsController"} | |||
| %div{"ng-controller" => "CredentialsController", "vm-scope" => main_scope} | |||
There was a problem hiding this comment.
Easy enough fix...I like that :)
AparnaKarve
reviewed
Mar 17, 2017
| @@ -4,7 +4,7 @@ ManageIQ.angular.app.controller('CredentialsController', ['$scope', '$attrs', fu | |||
| vm.vmScope = function() { | |||
| return $scope.$eval($attrs.vmScope); | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
Can you get rid of this file altogether from this PR? since it's not really adding anything.
There was a problem hiding this comment.
Oh, sorry, there was a trailing whitespace.. I guess we don't need to remove it.. will do :)
|
@ZitaNemeckova Why is this commit 754d023 linked to this PR? Do we still need those changes? |
|
@AparnaKarve because this fixes the issue @cben was seeing :). |
Introduced in #425, `CredentialsController` needs a `vm-scope` attribute to be able to determine the correct scope. This change was not done in app/views/layouts/angular/_auth_service_account_angular.html.haml which caused adding a GCE provider to be broken. Fixing.
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/ea7987da7e7b9bfcbff4d339920069039f4b0e67 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to Compute > Clouds > Providers, create a new provider.
Pick the GCE type.
Before
(And the Validate button is broken)
Now .. it works.
Introduced in #425,
CredentialsControllerneeds avm-scopeattribute to be able to determine the correct scope.This change was not done in
app/views/layouts/angular/_auth_service_account_angular.html.hamlwhich caused adding a GCE provider to be broken.Fixing.
Cc @AparnaKarve , @ZitaNemeckova