[cypress] Breakup and remove commands.js

[NickLaMuro]

Breaks the file into multiple files of two different categories:

• commands
• assertions

This is mostly a pedantic commit, but I figured it made sense to do this now and set precedence before others start contributing and use this as a reference. If for whatever reason it is highly disliked (I guess if there is a contigency of peeps who really like "long line files" I am unware of), we can close as well.

Links

• Example run on CI here: Test Cypress on Travis manageiq-cross_repo-tests#150

[NickLaMuro]

@miq-bot assign @himdel

[NickLaMuro]

@miq-bot add_labels cypress, refactoring

[NickLaMuro]

@miq-bot add_label test

[himdel]

I agree in principle, but depending on how pedantic you want to get.... :)

• expect_explorer_title vs expect_show_list_title should ideally be just expect_title which can figure out where we are (so I'd keep them together)

• menuItems is perhaps more of an assert than a command (but not sure how useful it is really, now that it reads window.ManageIQ.menu instead of parsing the info from the menu html)

• accordion is perhaps more related to explorers than to menus

But the structure makes sense, so, feel free to -Wno-pedantic me :D 👍

EDIT: debride spec failed on network error, restarted

[NickLaMuro]

@himdel I actually agree with all of the critique, so I will look at making the changes.

I was considering combining the titles myself, just wasn't sure what a good name was, but I will go with the "obviously simple" one you suggested.

[NickLaMuro]

Okay, upon further inspection, I am going to retract my changes to menuItems (was going to change it to something like expect_menu_items), but since it doesn't seem to be used in an assert-type-fashion currently:

manageiq-ui-classic/cypress/integration/ui/menu.spec.js

Lines 7 to 15 in d6d76be

	cy.menuItems()
	.then((menu) => {
	cy.log(menu);
	expect(menu.length > 9).to.equal(true);
	expect(menu[0].title).to.equal('Overview');
	expect(menu[0].items[1].title).to.equal('Reports');
	expect(menu[2].items[1].items[3].title).to.equal('Virtual Machines');
	});

Used to support some assertions, but doesn't actually do the asserting itself.

Maybe we can make helpers for that in the future, but I think for now, just getting the structure right.

---

That said, will still push the other two changes... hold plz.

[miq-bot]

Checked commit NickLaMuro@271be06 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆