Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and delete the code related to the old provider forms #7251

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

skateman
Copy link
Member

✂️ 🚽 🔥 💧 🦛

ManageIQ/manageiq#18818

@himdel
Copy link
Contributor

himdel commented Aug 10, 2020

EmsCommon mixin - new and edit are also dead now, right?

it also has all the retrieve_ methods used to populate selects in the old form - provider regions, openstack api versions, security protocols.

EDIT: new/edit are still alive and kicking

@himdel
Copy link
Contributor

himdel commented Aug 10, 2020

Tested infra, cloud, phinfra, container, network providers, * storage managers, and (partially, no providers) configuration.
Looks like new/edit still work just fine wherever available, the same goes for textual summaries, overview screens, show_list and topologies.

I think this is good to go 👍

(Just the EmsCommon#retrieve_ methods please, if you agree? :))

@skateman
Copy link
Member Author

skateman commented Aug 10, 2020

Yeah, the edit and new routes are still drawing the views that contain the forms. Deleting the set_form_vars and all its children, like retrieve_*...

@@ -80,7 +50,7 @@ def restful?
############################
# Special EmsCloud link builder for restful routes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: EmsCloud

@miq-bot
Copy link
Member

miq-bot commented Aug 11, 2020

Checked commit skateman@775acdd with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
24 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby25, which recognizes
warning: 2.5.8-compliant syntax, but you are running 2.5.7.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@himdel himdel merged commit 06b0235 into ManageIQ:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants