Fix menu.spec.js #7192
Merged
Fix menu.spec.js #7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
approved these changes
Jul 10, 2020
himdel
reviewed
Jul 15, 2020
|
LGTM :) |
|
👍 |
NickLaMuro
force-pushed
the
cypress-fix-menu-spec
branch
from
fb18588 to
40887ef
Compare
By using a `cy.get` with this command, it forces a `wait` for the DOM to load with the menu. Using `cy.window` doesn't (seem to) do that. This probably could be smaller, but this is a workaround to fix the currently breaking tests using this method (currently only `menu.spec.js`).
Clicking top level menu items is no longer supported with the Carbon styles, so fixing the specs to better reflect the current functionality, or commenting out places where it isn't valid. Most likely broken because of these changes: ManageIQ#6963
NickLaMuro
force-pushed
the
cypress-fix-menu-spec
branch
from
40887ef to
95de4e6
Compare
|
Checked commits NickLaMuro/manageiq-ui-classic@9d7bee7~...95de4e6 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with the spec:
menuItemswas not doing any form of a "wait" before trying to fetch the itemsThis test file should pass now.
Links