Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show hover text correctly on Copy catalog item button #7184

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Show hover text correctly on Copy catalog item button #7184

merged 1 commit into from
Jul 7, 2020

Conversation

h-kataria
Copy link
Contributor

Fixes #6046

before
Screenshot from 2020-07-06 17-47-24

after
Screenshot from 2020-07-06 17-48-21

Screenshot from 2020-07-06 17-47-49

@h-kataria h-kataria requested a review from himdel July 6, 2020 21:50
himdel
himdel reviewed Jul 7, 2020
View reviewed changes
app/helpers/application_helper/toolbar/servicetemplate_center.rb
@@ -36,7 +36,6 @@ class ApplicationHelper::Toolbar::ServicetemplateCenter < ApplicationHelper::Too
button(
:catalogitem_copy,
'pficon pficon-edit fa-lg',
N_('This Item cannot be copied'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button(id, icon, title, text, keys = {}) .. we do need 2 labels,

something like

t = N_('Copy Selected Item'),
t,

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed.

@h-kataria h-kataria force-pushed the fix_hover_text_on_copy_button branch from b201397 to c017bfc Compare July 7, 2020 18:52
@miq-bot
Copy link
Member

miq-bot commented Jul 7, 2020

Checked commit h-kataria@c017bfc with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

@himdel himdel merged commit 0401439 into ManageIQ:master Jul 7, 2020
simaishi pushed a commit that referenced this pull request Jul 7, 2020
@himdel @simaishi
Merge pull request #7184 from h-kataria/fix_hover_text_on_copy_button
b8b14ec 
Show hover text correctly on Copy catalog item button

(cherry picked from commit 0401439)
@simaishi
Copy link
Contributor

simaishi commented Jul 7, 2020

Jansa backport details:

$ git log -1
commit b8b14ec5e669debf7912e2a91bc68c67aeb7c76e
Author: Martin Hradil <[email protected]>
Date:   Tue Jul 7 21:35:31 2020 +0200

    Merge pull request #7184 from h-kataria/fix_hover_text_on_copy_button

    Show hover text correctly on Copy catalog item button

    (cherry picked from commit 040143957b63ed3495f67934d8c31797faa27335)

@h-kataria h-kataria deleted the fix_hover_text_on_copy_button branch January 18, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel left review comments

Assignees

@himdel himdel

Labels
bug jansa/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can copy catalogue item that should be disabled
4 participants
@h-kataria @miq-bot @simaishi @himdel