Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only set object_ids if in a form. #7183

Conversation

h-kataria
Copy link
Contributor

When clicking on a breadcrumb link while in a form without cancelling out of the form, code was setting object_ids from previously stored data in @edit causing not to load correct records in the list view.

Fixes #5383

When clicking on a breadcrumb link while in a form without cancelling out of the form, code was setting `object_ids` from previously stored data in `@edit` causing not to load correct records in the list view.

Fixes ManageIQ#5383
@miq-bot
Copy link
Member

miq-bot commented Jul 6, 2020

Checked commit h-kataria@5a50c9a with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@himdel
Copy link
Contributor

himdel commented Jul 7, 2020

LGTM, we do not cache @in_a_form in session, it only gets set explicitly and preserved through ReportDataAdditionalOptions, this should work, as long as we're setting @in_a_form = true in the right screens :).

@himdel himdel merged commit feef962 into ManageIQ:master Jul 7, 2020
simaishi pushed a commit that referenced this pull request Jul 7, 2020
…rumb_is_clicked

only set `object_ids` if in a form.

(cherry picked from commit feef962)
@simaishi
Copy link
Contributor

simaishi commented Jul 7, 2020

Jansa backport details:

$ git log -1
commit 4a7ac6da7d57ed5ba1cb704541b38df25b66afe5
Author: Martin Hradil <[email protected]>
Date:   Tue Jul 7 19:56:29 2020 +0200

    Merge pull request #7183 from h-kataria/fix_loading_list_after_breadcrumb_is_clicked

    only set `object_ids` if in a form.

    (cherry picked from commit feef9627cc91b8afd3a894b5992e1b351fa7a613)

@h-kataria h-kataria deleted the fix_loading_list_after_breadcrumb_is_clicked branch January 18, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumbs leads to wrong result All Vm & Template
4 participants