Moved common code to a method to reset tier details when switching Type. #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue when user tries to change Rate type on a Add Chargeback Rate form, with the fix it should reload form to show Storage/Compute fields when type is changed.
|
Checked commit h-kataria@492bfd9 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
simaishi
pushed a commit
that referenced
this pull request
Jun 29, 2020
…ching_type_on_new_record_form Moved common code to a method to reset tier details when switching Type. (cherry picked from commit 65660b1)
|
Jansa backport details: |
h-kataria
deleted the
reload_tier_details_when_switching_type_on_new_record_form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when user tries to change Rate type on a Add Chargeback Rate form, with the fix it should reload form to show Storage/Compute fields when type is changed.
before
after
