Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the physical infra provider forms with the DDF-based new one #7091

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

skateman
Copy link
Member

@skateman skateman commented May 29, 2020

There are just two physical infra providers with a fairly easy schema to migrate.

Depends on:
ManageIQ/manageiq-providers-redfish#115
ManageIQ/manageiq-providers-lenovo#304

Fixes: #6855
Parent issue: ManageIQ/manageiq#18818

@miq-bot
Copy link
Member

miq-bot commented May 29, 2020

Checked commit skateman@9a9dac3 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
3 files checked, 4 offenses detected

app/views/ems_physical_infra/edit.html.haml

  • ⚠️ - Line 1 - Layout/TrailingBlankLines: Final newline missing.
  • ⚠️ - Line 1 - Line is too long. [207/160]

app/views/ems_physical_infra/new.html.haml

  • ⚠️ - Line 1 - Layout/TrailingBlankLines: Final newline missing.
  • ⚠️ - Line 1 - Line is too long. [165/160]

Copy link
Contributor

@h-kataria h-kataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, was able to verify new form in UI. Ready to be merged once dependent PRs are merged.

@h-kataria h-kataria self-assigned this Jun 3, 2020
@skateman
Copy link
Member Author

Dependencies resolved, this can go in @h-kataria @himdel

@h-kataria h-kataria merged commit ebb397b into ManageIQ:master Jun 26, 2020
@skateman skateman deleted the physical-infra-forms branch June 26, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form conversion: Compute/Physical infrastructure/ Providers Add a new / edit
4 participants