Fix failing EmsContainerControllerSpec

[mzazrivec]

Fixing the following failure:

1) EmsContainerController.update_ems_button_detect with route set detects openshift prometheus alert route
     Failure/Error: expect(mock_client).to receive(:discover)
     
       (Double "kubeclient").discover(*(any args))
           expected: 1 time with any arguments
           received: 2 times with any arguments
     # ./spec/controllers/ems_container_controller_spec.rb:74:in `block (4 levels) in <top (required)>'
  2) EmsContainerController.update_ems_button_detect with route set tolerates detection exceptions
     Failure/Error: expect(mock_client).to receive(:discover)
     
       (Double "kubeclient").discover(*(any args))
           expected: 1 time with any arguments
           received: 2 times with any arguments
     # ./spec/controllers/ems_container_controller_spec.rb:74:in `block (4 levels) in <top (required)>'
  3) EmsContainerController.update_ems_button_detect with route set detects openshift prometheus metric route
     Failure/Error: expect(mock_client).to receive(:discover)
     
       (Double "kubeclient").discover(*(any args))
           expected: 1 time with any arguments
           received: 2 times with any arguments
     # ./spec/controllers/ems_container_controller_spec.rb:74:in `block (4 levels) in <top (required)>'
  4) EmsContainerController.update_ems_button_detect with route set detects openshift hawkular metric route
     Failure/Error: expect(mock_client).to receive(:discover)
     
       (Double "kubeclient").discover(*(any args))
           expected: 1 time with any arguments
           received: 2 times with any arguments
     # ./spec/controllers/ems_container_controller_spec.rb:74:in `block (4 levels) in <top (required)>'

[skateman]

I'd rather go with:

Suggested change

	expect(mock_client).to receive(:discover).twice
	expect(mock_client).to receive(:discover).at_least(:once)

as this is a mock and the amount of discover might change in the future.

[skateman]

Also if we're using allow above, it's pointless to have an expect here...

[mzazrivec]

Fixed.

[miq-bot]

Checked commit mzazrivec@e9c12b2 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[skateman]

[simaishi]

Jansa backport details:

$ git log -1
commit ffec492ccc3f5f7fa094a1a180f0c9f7231cc5c7
Author: Halász Dávid <[email protected]>
Date:   Mon May 18 14:06:06 2020 +0200

    Merge pull request #7051 from mzazrivec/fix_failing_ems_container_spec

    Fix failing EmsContainerControllerSpec

    (cherry picked from commit 81d4bdd8f2986de4888e5964c8b6550e7e5ba2e0)