-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace old angular config provider form with the new ProviderForm #7047
Conversation
f14f9e5
to
b28dc2d
Compare
b28dc2d
to
ddeeb4c
Compare
Checked commit skateman@ddeeb4c with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint app/views/ems_configuration/edit.html.haml
app/views/ems_configuration/new.html.haml |
Note that there's an issue with setting the name in the provider PR. But other than that, everything should be working. |
@skateman found couple of issues, am missing something missing in my environment, I have ManageIQ/manageiq-providers-foreman#62 checked out locally
|
@h-kataria forgot to mention that ManageIQ/manageiq-providers-foreman#62 needs a rebase, but asked Adam to do that on the PR as well. |
@skateman after I rebased ManageIQ/manageiq-providers-foreman#62 i edited an existing Foreman Provider, this time all fields were populated in the form, but after i edited the zone of the provider and pressed save, that cleared my saved url/username/password data. |
@h-kataria yeah, it's a delegation error in the provider PR, I'll make some suggestions there. |
@h-kataria this is ready for a final round, all deps are in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 works for me
Depends on: ManageIQ/manageiq-providers-foreman#62
Parent issue: ManageIQ/manageiq#18818
Before:
After:
This change will allow us to add any other configuration management provider on this form.
@miq-bot add_label pending core