Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gettext to title of a tab #7035

Merged
merged 1 commit into from
May 8, 2020
Merged

Add gettext to title of a tab #7035

merged 1 commit into from
May 8, 2020

Conversation

ZitaNemeckova
Copy link
Contributor

Fixes #7023

Steps to Reproduce:

  • Log into MIQ UI with non en_US locale
  • Navigate to Storage -> Block Storage -> Volume Types
  • Observe Cloud Volume Types is in English.

Before:
Screenshot 2020-05-06 at 13 43 33
After:
Screenshot 2020-05-06 at 13 43 59

@miq-bot add_label bug, jansa/no, internationalization

@miq-bot assign @mzazrivec

@miq-bot
Copy link
Member

miq-bot commented May 6, 2020

Checked commit ZitaNemeckova@eae7529 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 1 offense detected

app/views/layouts/_tabs.html.haml

  • ⚠️ - Line 65 - Avoid using instance variables in partials views

@h-kataria h-kataria merged commit f3e3979 into ManageIQ:master May 8, 2020
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label ivanchuk/yes

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label jansa/yes
@miq-bot remove_label jansa/no

@ZitaNemeckova ZitaNemeckova deleted the translate_volume_type_title branch May 11, 2020 07:08
@miq-bot
Copy link
Member

miq-bot commented May 11, 2020

@ZitaNemeckova Cannot remove the following label since they require triage team permissions: jansa/no

simaishi pushed a commit that referenced this pull request May 11, 2020
@h-kataria @simaishi
Merge pull request #7035 from ZitaNemeckova/translate_volume_type_title
786c53d 
Add gettext to title of a tab

(cherry picked from commit f3e3979)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 786c53d69567a8960a6557943a36f2f8193507d7
Author: Harpreet Kataria <[email protected]>
Date:   Fri May 8 16:18:36 2020 -0400

    Merge pull request #7035 from ZitaNemeckova/translate_volume_type_title

    Add gettext to title of a tab

    (cherry picked from commit f3e3979c1607a2b71639c5afd173112159456457)

@mzazrivec mzazrivec mentioned this pull request Nov 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug internationalization jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage - Block Storage - Volume Types page has entry in English
7 participants
@ZitaNemeckova @miq-bot @simaishi @Fryguy @chessbyte @h-kataria @mzazrivec