Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid login message #7034

Merged
merged 1 commit into from
May 5, 2020
Merged

Fix invalid login message #7034

merged 1 commit into from
May 5, 2020

Conversation

ZitaNemeckova
Copy link
Contributor

Introduced by ManageIQ/manageiq#20087

Fixes test failure on master:

Failed examples:
rspec ./spec/controllers/dashboard_controller/verify_user_spec.rb:73 # DashboardController validate_user fails for an invalid user
rspec ./spec/controllers/dashboard_controller/verify_user_spec.rb:66 # DashboardController validate_user fails for an existing user with wrong password

@miq-bot add-label jansa/no

ping @skateman

@miq-bot
Copy link
Member

miq-bot commented May 5, 2020

Checked commit ZitaNemeckova@687fd48 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@himdel himdel merged commit a24acba into ManageIQ:master May 5, 2020
@himdel himdel self-assigned this May 5, 2020
@himdel
Copy link
Contributor

himdel commented May 5, 2020 •
edited
Loading

Added jansa/yes? because ManageIQ/manageiq#20087 is.

simaishi pushed a commit that referenced this pull request May 8, 2020
@himdel @simaishi
Merge pull request #7034 from ZitaNemeckova/fix_red
956a025 
Fix invalid login message

(cherry picked from commit a24acba)
@simaishi
Copy link
Contributor

simaishi commented May 8, 2020

Jansa backport details:

$ git log -1
commit 956a025a6228110bf9c177a9cc9ad21573d49768
Author: Martin Hradil <[email protected]>
Date:   Tue May 5 12:11:45 2020 +0000

    Merge pull request #7034 from ZitaNemeckova/fix_red

    Fix invalid login message

    (cherry picked from commit a24acba403be006f3663c5e0d699ddc4143c532b)

@h-kataria h-kataria added the test label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himdel himdel

Labels
bug jansa/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZitaNemeckova @miq-bot @himdel @simaishi @gtanzillo @h-kataria