Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu - sort Providers menu together, singular #6994

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Menu - sort Providers menu together, singular #6994

merged 1 commit into from
Apr 24, 2020

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Apr 24, 2020

Now the menu goes...

Overview
Services
Compute
Network (changed to singular)
Storage
Configuration
Automation
Migration
Control
Monitor

Cc @h-kataria , @Fryguy

@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2020

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/ee298fe02a50dd834f4f0ce58c4a6b16c76ede86 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@himdel
Copy link
Contributor Author

himdel commented Apr 24, 2020

foo

@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria self-assigned this Apr 24, 2020
@h-kataria h-kataria self-requested a review April 24, 2020 16:28
@h-kataria h-kataria merged commit b7c04d1 into ManageIQ:master Apr 24, 2020
@h-kataria h-kataria mentioned this pull request Apr 24, 2020
13 tasks
@himdel himdel deleted the menu-changes branch April 24, 2020 16:31
simaishi pushed a commit that referenced this pull request May 1, 2020
Menu - sort Providers menu together, singular

(cherry picked from commit b7c04d1)
@simaishi
Copy link
Contributor

simaishi commented May 1, 2020

Jansa backport details:

$ git log -1
commit 572e3934faf51d4fd53d8d1fcdff02ab5cb93209
Author: Harpreet Kataria <[email protected]>
Date:   Fri Apr 24 12:30:20 2020 -0400

    Merge pull request #6994 from himdel/menu-changes

    Menu - sort Providers menu together, singular

    (cherry picked from commit b7c04d1a25d12234a441a0bd24c36e1c9b1a7fec)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants