Fix Persistent Volume link to ems_container

[zakiva]

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1432117

Fixes broken link http://localhost:3000/ems_container/show/6
to http://localhost:3000/ems_container/6

[zakiva]

@miq-bot add_label compute/containers, bug

[zakiva]

@simon3z @zeari Please review

[simon3z]

@zakiva was this caused by some sort of refactoring? Can you spot what was the change that broke this and then make sure we don't have any other places that needs to be fixed/updated?

[simon3z]

@zakiva was this caused by some sort of refactoring? Can you spot what was the change that broke this and then make sure we don't have any other places that needs to be fixed/updated?

@zakiva on top of that, can we also have tests to make sure that this won't happen again?

[miq-bot]

Some comments on commit zakiva@57b0e1f

spec/views/layouts/listnav/_persistent_volume.html.haml_spec.rb

• ⚠️ - 12 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commit zakiva@57b0e1f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

spec/views/layouts/listnav/_persistent_volume.html.haml_spec.rb

• ❕ - Line 19, Col 121 - Metrics/LineLength - Line is too long. [143/120]

[zakiva]

@zakiva was this caused by some sort of refactoring? Can you spot what was the change that broke this and then make sure we don't have any other places that needs to be fixed/updated?
@zakiva on top of that, can we also have tests to make sure that this won't happen again?

@simon3z I think it's related to a pretty old refactor when we started using restful path,
added a test for that. I don't see other places where we have this problem.

Also, I believe we should backport it to Euwe.

@miq-bot add_label euwe/yes

[simaishi]

Euwe backport (to manageiq repo) details:

$ git log -1
commit d445d0329c9cbf8f96a35856bbab4625d0dc46e6
Author: Martin Povolny <[email protected]>
Date:   Wed Mar 22 11:58:07 2017 +0100

    Merge pull request #692 from zakiva/fix_volume_link
    
    Fix Persistent Volume link to ems_container
    (cherry picked from commit 6564c612bf353470dd2e74c201ba63933c3d3547)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1436226