Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI support for Pod to PV relationship #682

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Add UI support for Pod to PV relationship #682

merged 1 commit into from
Apr 27, 2017

Conversation

nimrodshn
Copy link
Contributor

@nimrodshn nimrodshn commented Mar 14, 2017 •
edited
Loading

This is part of an effort to support the Pod to PV relationship - Such that one could be able to view which pods are using a given persistent volume(if the are any).
screenshot from 2017-03-14 18-00-08
After click:
screenshot from 2017-03-14 18-00-15

cc: @simon3z @zakiva

related to: ManageIQ/manageiq#14231
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1402329

@miq-bot miq-bot added the wip label Mar 14, 2017
@nimrodshn nimrodshn force-pushed the add_pvc_relationship branch 2 times, most recently from a82b5f8 to 3b9974a Compare March 14, 2017 16:11
nimrodshn
nimrodshn commented Mar 14, 2017
View reviewed changes
app/helpers/persistent_volume_helper/textual_summary.rb
def textual_pods_using_persistent_volume
link = url_for_only_path(:id => @record.id, :action => "show", :display => "container_groups")
textual_link(@record.container_groups, :as => ContainerGroup, :link => link)
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinpovolny textual_link didn't generate the right url since it is a complex relationship. Any other way to do this other than the above?

@nimrodshn nimrodshn force-pushed the add_pvc_relationship branch from 3b9974a to 8fe1fe8 Compare March 14, 2017 17:52
@nimrodshn nimrodshn changed the title [WIP] Add UI support for Pod to PV relationship Add UI support for Pod to PV relationship Apr 24, 2017
@miq-bot miq-bot removed the wip label Apr 24, 2017
@nimrodshn nimrodshn mentioned this pull request Apr 24, 2017
Merged
@nimrodshn
Copy link
Contributor Author

nimrodshn commented Apr 24, 2017 •
edited
Loading

PTAL @simon3z @zakiva @moolitayer

@moolitayer
Copy link

@nimrodshn please add the relevant bugzilla (top comment)
@miq-bot add_label compute/containers, fine/yes, pending core

@nimrodshn
Copy link
Contributor Author

@moolitayer Done.

@moolitayer
Copy link

@nimrodshn you are missing a navbar addition

@nimrodshn nimrodshn force-pushed the add_pvc_relationship branch 2 times, most recently from fe7b4df to 2abb074 Compare April 24, 2017 16:44
@nimrodshn
Copy link
Contributor Author

@moolitayer Done, PTAL.

@zakiva
Copy link
Contributor

zakiva commented Apr 24, 2017

@nimrodshn need to add count of records in the side bar button, e.g. pods(2), and if there are no pods at all the link should be disabled (same as in other entities).

@nimrodshn nimrodshn force-pushed the add_pvc_relationship branch from 2abb074 to 09f55cd Compare April 24, 2017 19:32
@nimrodshn
Copy link
Contributor Author

@zakiva Added, PTAL.
screenshot from 2017-04-24 22-29-19
screenshot from 2017-04-24 22-33-22
cc: @simon3z

@nimrodshn
Add UI support for Pod to PV relationship
4586f47 
refactored small mistakes

refactored small mistakes

refactored small mistakes

refactored small mistakes

refactoring

refactoring

refactored navbar

refactored navbar
@nimrodshn nimrodshn force-pushed the add_pvc_relationship branch from 09f55cd to 4586f47 Compare April 24, 2017 19:36
@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2017

Checked commit nimrodshn@4586f47 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🍪

@simon3z
Copy link
Contributor

simon3z commented Apr 24, 2017

@nimrodshn @moolitayer do we need to fix tests for travis?

@nimrodshn
Copy link
Contributor Author

@simon3z ran the tests locally and they pass - its just pending the back-end merge.

@moolitayer
Copy link

@miq-bot add_label blocker

@nimrodshn
Copy link
Contributor Author

@himdel PTAL ?

@moolitayer
Copy link

@nimrodshn @moolitayer do we need to fix tests for travis?

Test failure is due to missing backend. @nimrodshn is working on getting backend reviewed and merged.

@dclarizio dclarizio added the bug label Apr 25, 2017
@moolitayer
Copy link

@nimrodshn Please restart tests

@martinpovolny
Copy link
Member

Restarted travis.

@nimrodshn
Copy link
Contributor Author

@martinpovolny can you review this please? or merge unless there aren't any offenses?

@martinpovolny martinpovolny added this to the Sprint 60 Ending May 8, 2017 milestone Apr 27, 2017
@martinpovolny martinpovolny merged commit 5630694 into ManageIQ:master Apr 27, 2017
simaishi pushed a commit that referenced this pull request May 1, 2017
@martinpovolny @simaishi
Merge pull request #682 from nimrodshn/add_pvc_relationship
99a0258 
Add UI support for Pod to PV relationship
(cherry picked from commit 5630694)

https://bugzilla.redhat.com/show_bug.cgi?id=1447049
@simaishi
Copy link
Contributor

simaishi commented May 1, 2017

Fine backport details:

$ git log -1
commit 99a02588c1d0f539f1f33fe3ec11100e48c6a4ee
Author: Martin Povolny <[email protected]>
Date:   Thu Apr 27 07:12:50 2017 +0200

    Merge pull request #682 from nimrodshn/add_pvc_relationship
    
    Add UI support for Pod to PV relationship
    (cherry picked from commit 56306949355252a0937dba5426d32df4736e7f3c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
blocker bug compute/containers fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nimrodshn @moolitayer @zakiva @miq-bot @simon3z @martinpovolny @simaishi @dclarizio