Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving of ems_refresh_worker and ems_metrics_collector_worker #6678

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

ZitaNemeckova
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1799443

Introduced by #5528

Steps to reproduce:

  1. Navigate to Configuration -> Settings -> (appliance) -> Workers
  2. Change Refresh worker Memory threshold to something else
  3. Change C & U Data Collectors Memory threshold and Count to something else
  4. Save the changes
  5. Refresh the page

Before:
Values stay same as original ones
After:
Values are changed to ones you selected

Just making loaded data same as sent one. See

ems_metrics_collector_worker: {
defaults: {
memory_threshold: parseWorker(wb.queue_worker_base.ems_metrics_collector_worker.defaults).bytes || baseMemDefault,
count: selectCount(wb.queue_worker_base.ems_metrics_collector_worker.defaults.count),
},
},
and
ems_refresh_worker: {
defaults: {
memory_threshold: parseWorker(wb.queue_worker_base.ems_refresh_worker.defaults).bytes || baseMemDefault,
},

@miq-bot add_label bug, ivanchuk/yes

@miq-bot
Copy link
Member

miq-bot commented Feb 13, 2020

Checked commit ZitaNemeckova@e27a194 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Feb 14, 2020
@mzazrivec mzazrivec added this to the Sprint 130 Ending Feb 17, 2020 milestone Feb 14, 2020
@mzazrivec mzazrivec merged commit cbef87d into ManageIQ:master Feb 14, 2020
simaishi pushed a commit that referenced this pull request Feb 21, 2020
Fix saving of ems_refresh_worker and ems_metrics_collector_worker

(cherry picked from commit cbef87d)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805845
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 7f76eb878d827abf664a580ff0a7edf1241b910c
Author: Milan Zázrivec <[email protected]>
Date:   Fri Feb 14 10:53:55 2020 +0100

    Merge pull request #6678 from ZitaNemeckova/fix_workers

    Fix saving of ems_refresh_worker and ems_metrics_collector_worker

    (cherry picked from commit cbef87d5c81055dddb9e5d3f1a8854d39adc1fd2)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants