Fix toolbar on Reports tab on Overview -> Utilization screen #6624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
ZitaNemeckova
force-pushed
the
fix_util_toolbar
branch
from
58eed1b to
c3c2708
Compare
|
Checked commits ZitaNemeckova/manageiq-ui-classic@12d91af~...634713d with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot remove_label wip |
miq-bot
changed the title
mzazrivec
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6608
Show toolbar when Report tab selected
Go to Overview -> Utilization -> select a Provider -> click Report Tab -> No Download button
Before:
After:
Do Not show toolbar when no data in Report
Go to Overview -> Utilization -> select a Provider -> click Report Tab -> click another Provider -> click Download button and get an error
Before:
[----] F, [2020-01-20T16:02:10.608136 #4597:3fe027b4a4b4] FATAL -- : Error caught: [NoMethodError] undefined method '[]' for nil:NilClass /ManageIQ/manageiq-ui-classic/app/controllers/utilization_controller.rb:232:in 'summ_hashes' /ManageIQ/manageiq-ui-classic/app/controllers/utilization_controller.rb:74:in 'report_download'After:
@miq-bot add_label wip, bug, toolbars, ivanchuk/no