Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open and close file objects using read to avoid leaking #6597

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Jan 9, 2020

Followup to: #6596

@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2020

Checked commit jrafanie@05e02aa with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 11 offenses detected

app/controllers/application_controller/miq_request_methods.rb

app/controllers/application_controller/performance.rb

app/controllers/application_controller/timelines.rb

app/presenters/menu/yaml_loader.rb

app/services/charts_layout_service.rb

spec/controllers/application_controller/report_data_spec.rb

spec/product/reports_spec.rb

spec/services/charts_layout_service_spec.rb

@mzazrivec mzazrivec self-assigned this Jan 10, 2020
@mzazrivec mzazrivec added this to the Sprint 128 Ending Jan 20, 2020 milestone Jan 10, 2020
@mzazrivec mzazrivec merged commit 0cd64bf into ManageIQ:master Jan 10, 2020
@jrafanie jrafanie deleted the leak_no_io_objects branch May 5, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants