Delete Resume button for VMs and Instances #6581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZitaNemeckova
force-pushed
the
fix_resume_action
branch
from
41bd113 to
cbaf14f
Compare
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1738584 - The Resume button checks that a VM has start feature but never calls a method. Generic code that handles all Power buttons tries to call a method instance_resume that never existed. - It seems that it never worked since Anand. There's no method for Resume button. - No VM has some kind of resume method(I would expect raw_resume or resume based on other Power action methods naming) Leaving Provider Resume related code as is.
ZitaNemeckova
force-pushed
the
fix_resume_action
branch
from
cbaf14f to
f368d33
Compare
|
Checked commit ZitaNemeckova@f368d33 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot remove_label wip @h-kataria please have a look, thanks:) |
ZitaNemeckova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1738584
Go to:
Compute -> Clouds -> Instances -> check one or more -> toolbar Power -> click Resume
Before:
Nothing happens in UI but there's an error in log
After: no Resume button
Removing because:
I didn't find any mention of
resumewithVmOrTemplate.descendants.select{ |x| x.instance_methods.include?(:resume)}.count,VmOrTemplate.descendants.select{ |x| x.instance_methods.include?(:raw_resume)}.count,VmOrTemplate.descendants.select{ |x| x.methods.include?(:resume)}.countandVmOrTemplate.descendants.select{ |x| x.methods.include?(:raw_resume)}.countThe Resume button checks that a VM has start feature but never calls a method. Generic code that handles all Power buttons tries to call a method
instance_resumethat never existed in UI.It seems that it never worked since
Anand. There's no method for Resume button.No VM has some kind of resume method(I would expect
raw_resumeorresumebased on other Power action methods naming)Leaving Provider Resume related code as is.
@miq-bot add_label bug, ivanchuk/yes, hammer/yes, wip