Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tags to PxeServer and its items #6509

Merged
merged 8 commits into from
Jan 16, 2020
Merged

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Dec 9, 2019

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1454712

Depends on ManageIQ/manageiq#19612 (merged) and ManageIQ/manageiq#19662 (merged)

Go to: Compute -> Infrastructure -> PXE

Before:
image

After:
image
image
image

@miq-bot miq-bot changed the title Add Tags to PxeServer and its items [WIP] Add Tags to PxeServer and its items Dec 9, 2019
@miq-bot miq-bot added the wip label Dec 9, 2019
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label pending core, ivanchuk/no

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label pending core

@ZitaNemeckova ZitaNemeckova force-pushed the pxe-tags branch 3 times, most recently from 0c6e46c to 6dfa6dd Compare January 2, 2020 13:01
@miq-bot
Copy link
Member

miq-bot commented Jan 2, 2020

Checked commits ZitaNemeckova/manageiq-ui-classic@ca007ce~...090909f with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 12 offenses detected

app/helpers/application_helper/toolbar/pxe_image_center.rb

app/helpers/application_helper/toolbar/pxe_server_center.rb

app/helpers/application_helper/toolbar/pxe_servers_center.rb

app/helpers/application_helper/toolbar/windows_image_center.rb

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot add_label enhancement

@h-kataria please have a look, thanks :)

@miq-bot miq-bot changed the title [WIP] Add Tags to PxeServer and its items Add Tags to PxeServer and its items Jan 3, 2020
@miq-bot miq-bot added enhancement and removed wip labels Jan 3, 2020
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label pending core

@mzazrivec mzazrivec self-assigned this Jan 16, 2020
@mzazrivec mzazrivec added this to the Sprint 128 Ending Jan 20, 2020 milestone Jan 16, 2020
@mzazrivec mzazrivec merged commit 63e5a98 into ManageIQ:master Jan 16, 2020
@ZitaNemeckova ZitaNemeckova deleted the pxe-tags branch January 16, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants