Dialog Editor, ExplorerPresenter - make sure all ids are strings in javascript #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for regions > 9006, our bigint ids become floats in javascript, and can be off-by-one. This makes sure dialog editor works in those regions. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1769968
…nless nil Most of the code setting `presenter[:record_id]` or `:parent_id` is not doing the `.to_s` conversion necessary for javascript, so ExplorerPresenter should do it. (Also removes the now extra .to_s from the 2 calls that were actually right before.) Fixes toolbar Edit button not working on a service dialog detail screen. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1769968
himdel
changed the title
|
@miq-bot remove_label wip |
miq-bot
changed the title
|
Cc @martinpovolny (ExplorerPresenter id changes :)) |
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/f162d770786f02d05c9ce35d6b27ebb41bdad4ea~...4dfad619acff1fcfa08215c350a6d24a83f5b314 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2019
Dialog Editor, ExplorerPresenter - make sure all ids are strings in javascript (cherry picked from commit 747eb57) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1772932
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Dec 16, 2019
Dialog Editor, ExplorerPresenter - make sure all ids are strings in javascript (cherry picked from commit 747eb57) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1772933
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for regions > 9006, our bigint ids become floats in javascript, and can be off-by-one. (Original issue: #1405)
This makes sure the dialog editor works in those regions:
dialog_id_actionchange fixes the result of therequestDialogIddialog editor controller method, controlling where to load the dialog data fromExplorerPresenterchange fixes the toolbar (Edit) button failing (becuase it usesManageIQ.record.recordId, which was set to a number otherwise)to_sbecause it's handled in ExplorerPresenter now)Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1769968