-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Tags from Network Topology View and others #6351
Merged
martinpovolny
merged 2 commits into
ManageIQ:master
from
hstastna:RemoveTag_TopologyView
Nov 25, 2019
Merged
Remove Tags from Network Topology View and others #6351
martinpovolny
merged 2 commits into
ManageIQ:master
from
hstastna:RemoveTag_TopologyView
Nov 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@miq-bot add_label topology |
hstastna
force-pushed
the
RemoveTag_TopologyView
branch
from
October 30, 2019 15:22
12e8e50
to
eb3661d
Compare
hstastna
force-pushed
the
RemoveTag_TopologyView
branch
from
October 31, 2019 09:16
d625694
to
e36d498
Compare
Checked commits hstastna/manageiq-ui-classic@f31c5e5~...e36d498 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
hstastna
changed the title
[WIP] Remove Tags from Network Topology View and others
Remove Tags from Network Topology View and others
Oct 31, 2019
@miq-bot add_label changelog/yes |
Tested in UI. LGTM 👍 |
@h-kataria can this be |
simaishi
pushed a commit
that referenced
this pull request
May 12, 2020
Remove Tags from Network Topology View and others (cherry picked from commit 3a97fac) https://bugzilla.redhat.com/show_bug.cgi?id=1529718
Ivanchuk backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1529718
This PR completely removes Tags from all of the Topology Views.
Related PRs:
ManageIQ/manageiq#7931
Before: (Networks > Topology)
After: