Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tags from Network Topology View and others #6351

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

hstastna
Copy link

@hstastna hstastna commented Oct 30, 2019

RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1529718

This PR completely removes Tags from all of the Topology Views.

Related PRs:
ManageIQ/manageiq#7931


Before: (Networks > Topology)
network-before

After:
network-after

@hstastna
Copy link
Author

@miq-bot add_label topology

@hstastna hstastna force-pushed the RemoveTag_TopologyView branch from d625694 to e36d498 Compare October 31, 2019 09:16
@miq-bot
Copy link
Member

miq-bot commented Oct 31, 2019

Checked commits hstastna/manageiq-ui-classic@f31c5e5~...e36d498 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 0 offenses detected
Everything looks fine. 🍪

@hstastna hstastna changed the title [WIP] Remove Tags from Network Topology View and others Remove Tags from Network Topology View and others Oct 31, 2019
@miq-bot miq-bot removed the wip label Oct 31, 2019
@hstastna
Copy link
Author

hstastna commented Nov 4, 2019

@miq-bot add_label changelog/yes

@ZitaNemeckova
Copy link
Contributor

Tested in UI. LGTM 👍

@martinpovolny martinpovolny self-assigned this Nov 25, 2019
@martinpovolny martinpovolny added this to the Sprint 125 Ending Nov 25, 2019 milestone Nov 25, 2019
@martinpovolny martinpovolny merged commit 3a97fac into ManageIQ:master Nov 25, 2019
@simaishi
Copy link
Contributor

simaishi commented May 7, 2020

@h-kataria can this be ivanchuk/yes?

simaishi pushed a commit that referenced this pull request May 12, 2020
Remove Tags from Network Topology View and others

(cherry picked from commit 3a97fac)

https://bugzilla.redhat.com/show_bug.cgi?id=1529718
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit f3f7822deb34667acadd91452af727298bcc898e
Author: Martin Povolny <[email protected]>
Date:   Mon Nov 25 16:48:21 2019 +0100

    Merge pull request #6351 from hstastna/RemoveTag_TopologyView

    Remove Tags from Network Topology View and others

    (cherry picked from commit 3a97facb1cb95bd439a07a6e089ea4fd3c9f3550)

    https://bugzilla.redhat.com/show_bug.cgi?id=1529718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants