Separated the namespace and domain form #6335
Conversation
|
Just a naming thing at the start, let's prefix both forms with |
| expect(response).to have_css("namespace-form[namespace_path='namespace/path']") | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
I'm a little concerned about removing these specs, but I guess we no longer need them after ManageIQ/manageiq-api#647 is in.
|
I like this, but I guess someone from automate could check it out too. |
|
@skateman 'mkanoor' is an invalid reviewer, ignoring... |
|
@skateman 'tinaafitz' is an invalid reviewer, ignoring... |
|
@brumik does this work out of the box, or does it depend on any API PRs? |
|
Checked commits https://github.com/brumik/manageiq-ui-classic/compare/591503720313d30789b8df01d7adc6be5f7d5535~...8bff879e40453a521e90d6e83b4eb6d4d793faee with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This depends on ManageIQ/manageiq-api#699 |
|
This pull request is not mergeable. Please rebase and repush. |
Separating the namespace and the domain form. This PR is built on #5971 and also includes the tests.
Depends on:
Before:
After:
@miq-bot add_label react, hammer/no, ivanchuk/no, react, pending core, automation/automate
@miq-bot add_reviewer @Hyperkid123
@miq-bot add_reviewer @skateman
@miq-bot add_reviewer @rvsia
@miq-bot add_reviewer @karelhala