Add Refresh button to individual Dashboard Widget #6334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
|
Very nice work.. |
ZitaNemeckova
force-pushed
the
dashboard_widget_refresh_button
branch
from
affc588 to
77babd2
Compare
|
@miq-bot add_label pending core |
ZitaNemeckova
force-pushed
the
dashboard_widget_refresh_button
branch
2 times, most recently
from
cb08338 to
61b0cf1
Compare
h-kataria
reviewed
Nov 6, 2019
h-kataria
reviewed
Nov 6, 2019
h-kataria
reviewed
Nov 6, 2019
|
@miq-bot remove_label pending core |
ZitaNemeckova
force-pushed
the
dashboard_widget_refresh_button
branch
4 times, most recently
from
94d4d4e to
ccd0405
Compare
himdel
reviewed
Nov 11, 2019
ZitaNemeckova
force-pushed
the
dashboard_widget_refresh_button
branch
5 times, most recently
from
8c777b2 to
b7c370b
Compare
|
@miq-bot remove_label wip |
miq-bot
changed the title
…st MiqTask and hoping for the best :D
ZitaNemeckova
force-pushed
the
dashboard_widget_refresh_button
branch
from
a183351 to
786b0e0
Compare
ZitaNemeckova
force-pushed
the
dashboard_widget_refresh_button
branch
from
786b0e0 to
74bc8ba
Compare
ZitaNemeckova
force-pushed
the
dashboard_widget_refresh_button
branch
from
74bc8ba to
1bcc2c6
Compare
ZitaNemeckova
force-pushed
the
dashboard_widget_refresh_button
branch
from
5ace18b to
fef8ce1
Compare
himdel
reviewed
Nov 18, 2019
himdel
reviewed
Nov 18, 2019
|
LGTM 👍 , just waiting for green travis now :) (EDIT: that means #6428) |
|
Checked commits ZitaNemeckova/manageiq-ui-classic@c30f196~...d09c425 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1703068
This applies to all Dashboard Widgets except Menu ones.
Go to Overview -> Dashboard
Before:
After:
@miq-bot add_label enhancement, ivanchuk/no, cloud intel/dashboard, wip, core pending
TODO:
MiqTaskid fromMiqWidget.queue_generate_contentReturn MiqTask id from MiqWidget.queue_generate_content manageiq#19445 mergedEmsClusterin console