Allow performing SSA on Datastores in Datastore Clusters accordion

[hstastna]

Issue: #6241

There was an issue with Datastores and SSA: The selected Datastore was not accessible while performing SSA from the list of Datastores of selected Datastore Cluster.

Details:
In generic_button_operation method, called by scanstorage after clicking on Perform SmartState Analysis toolbar button, screen_redirection is called. However, in this method, logic for @lastaction different than "show_list" is missing (see). The result is that it calls show instead of show_list here (it does not 'go' into the proper condition and does not call return when it should so we fall into the next condition with show call). And this is simply wrong because we are in the list of Datastores, we want to call show_list.
I changed the condition and added some more possibilities for @lastaction, the same as it already is in a different place (for deleting Datastores, where it already fixes the same problem), see this. This all is just because @lastaction is very specific, it is set to "storage_pod_list". Not sure how important is to set @lastaction to such value but I am not going to change it.
For other methods, it simply works just because @lastaction is set to "show_list" or there is options[:redirect] present (in screen_redirection). Or, simply generic_button_operation is not called at all.

---

Before:

After:

[miq-bot]

Checked commit hstastna@b5c2040 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

[ZitaNemeckova]

@hstastna The breadcrumb changes after clicking on SSA.
From:

To:

It's not happening for Delete Datastores.

Otherwise it works perfectly :)

[himdel]

SSA = toolbar Configuration / Perform SmartState Analysis

[hstastna]

@ZitaNemeckova The issue here is that it is not happening for Delete Datastores. Right? Because I think that, originally, 'Datastores in .. Cluster' was missing in breadcrumbs.

[himdel]

@hstastna I think it's the other way - using a toolbar button that doesn't change the screen we're on should not change the breadcrumbs either.

So, on a list screen, neither Delete nor Perform SSA should change the breadcrumbs.

[ZitaNemeckova]

@hstastna @himdel It seems it happens for SSA for VMs too. So I would say it's out of scope for this PR. WDYT?

[ZitaNemeckova]

The breadcrumb issue is out of scope for this PR.

LGTM 👍

[hstastna]

I agree, partially with you, @himdel . Yes, breadcrumbs shouldn't be changed because of some action but I think that here, after the SSA, the breadcrumbs are finally right, and before the action they weren't - 'Datastores in .. Cluster' was missing there. Because, everywhere across MIQ, I can see that the title of the page is also in breadcrumbs. I don't see any reason to have it differently in this page.
So I think we need to fix the breadcrumbs how they 'look' before SSA here. But I can open a separate issue for this and we can discuss what's the proper solution.

[himdel]

Aah, agreed, the breadcrumbs should reflect the current screen.
So, they shouldn't change after the toolbar action, but should be that way even before that action.

Create the issue please and maybe @rvsia can point you to the right way of fixing this situation.

[himdel]

Ah, @ZitaNemeckova already created #6347 :)

EDIT: but #6348 is more correct re #6298 (comment)

[ZitaNemeckova]

Created an issue for it
#6347