Fixed placement alignment. #6238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
@romanblanco please make a review, thanks |
romanblanco
approved these changes
Sep 26, 2019
| %span.help-block{"ng-show" => "angularForm.cloud_tenant_id.$error.required"} | ||
| = _("Required") | ||
|
|
||
| .placement{"ng-if" => "vm.securityGroupModel.ems_id"} |
There was a problem hiding this comment.
I feel like we don't need to introduce a new class for the div, and just use a regular %div, since we don't have a special style for the placement class:
Suggested change
| .placement{"ng-if" => "vm.securityGroupModel.ems_id"} | |
| %div{"ng-if" => "vm.securityGroupModel.ems_id"} |
Hchrast
force-pushed
the
PlacementAlign
branch
from
029b838 to
813f644
Compare
|
Checked commit Hchrast@813f644 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
romanblanco
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1740647
Steps to Reproduce:
Before:
After:
