Add button tag to generic object form #6226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @h-kataria |
|
@miq-bot add_label bug, formatting/styling, hammer/yes, ivanchuk/yes |
h-kataria
approved these changes
Sep 23, 2019
|
Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/52c843ec48d4b5a6501001fbfdfec6d7edf41df7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 1, 2019
Add button tag to generic object form (cherry picked from commit 523d547) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767823
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces a div with a button tag for Delete buttons so that tabbing works properly
https://bugzilla.redhat.com/show_bug.cgi?id=1519494