Add the selected accessor to TreeNode::Node and clean up its to_h #6221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
requested review from
romanblanco,
ZitaNemeckova,
martinpovolny and
mzazrivec
|
@skateman The CI failures seem related. |
skateman
force-pushed
the
node-selected
branch
from
200c5cb to
7f33dd2
Compare
|
Checked commit skateman@7f33dd2 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this one from #6208, the change is harmless as the
selectedattribute is never being set yby the node itself. However, it will be significant when theTreeBuilder#overridemethods will start using it. Also thedelete_ifis no longer necessary into_has we have thecompact.@miq-bot add_label enhancement, technical debt, ivanchuk/no, trees
@miq-bot add_reviewer @romanblanco
@miq-bot add_reviewer @ZitaNemeckova
@miq-bot add_reviewer @martinpovolny
@miq-bot add_reviewer @mzazrivec