Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React header #6197

Merged
merged 34 commits into from
Dec 4, 2019
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
40c71fa
Changed icon styling and user_options template
fhlavac Aug 12, 2019
2f38e73
Added element parameter to ReactjsHelper
fhlavac Sep 17, 2019
b599e54
Added unified structure generating for any menu
fhlavac Sep 17, 2019
256584f
Created user-options component
fhlavac Sep 17, 2019
970c1ec
Created configuration component
fhlavac Sep 17, 2019
9f25a2f
Created help component
fhlavac Sep 17, 2019
0b77209
Created notifications component
fhlavac Sep 17, 2019
6a9f204
Created custom-logo component
fhlavac Sep 17, 2019
13208e4
Created superior right-section component
fhlavac Sep 17, 2019
0fab97c
Created top-navbar tests
fhlavac Sep 17, 2019
b6a1c6d
Code cleaning, minor fixes based on review
fhlavac Sep 19, 2019
5eee9ae
Added PropTypes and sorted component definitions
fhlavac Oct 2, 2019
e7eecec
Added miqChangeGroup and logoutInProgress
fhlavac Oct 24, 2019
5b07656
Updated tests
fhlavac Oct 24, 2019
a5ef07d
Removed value returning in logout onClick
fhlavac Oct 30, 2019
64f5e19
Update snapshots
fhlavac Nov 6, 2019
1462971
Merge menu_to_json() used in top and vertical nav
fhlavac Nov 7, 2019
4985e73
Update recursive-props after props renaming
fhlavac Nov 7, 2019
2e48cd6
Main-menu and top-navbar tests update
fhlavac Nov 7, 2019
03e5893
Remove currentGroup defined condition in user-opt
fhlavac Nov 13, 2019
ae1258f
Change const to var in event_notification_service
fhlavac Nov 20, 2019
8cb4c5b
Add target to HelpMenu item
fhlavac Nov 20, 2019
bb0dedb
Remove => function from event_notification_service
fhlavac Nov 20, 2019
382979d
Update snapshots
fhlavac Nov 20, 2019
0623dc2
Move getTargetByType function to global helpers
fhlavac Nov 20, 2019
5716ce6
Use getTargetByType function in help-menu
fhlavac Nov 20, 2019
de2e175
Make currentUser required in props validation
fhlavac Nov 20, 2019
f25dd2c
Convert ids of menu items to string
fhlavac Nov 27, 2019
e50bdb0
Move notificationReducer to a separate file
fhlavac Nov 27, 2019
9ba4e24
Prefix top-navbar components defs with 'navbar.'
fhlavac Nov 27, 2019
aff7b17
Add prefix "navbar." to component names string
fhlavac Nov 27, 2019
e98b1d5
Add create(:user_with_group) to controllers
fhlavac Nov 27, 2019
d31458e
Add :user_with_group floating_ip_controller
fhlavac Nov 27, 2019
0ca1e44
Add prefix "navbar." in _right_section.html.haml
fhlavac Dec 4, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add :user_with_group floating_ip_controller
  • Loading branch information
fhlavac committed Dec 4, 2019
commit d31458ea9944361bc237ca263b6ef991ecf5e01b
2 changes: 1 addition & 1 deletion spec/controllers/floating_ip_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -71,7 +71,7 @@
before do
EvmSpecHelper.create_guid_miq_server_zone
@floating_ip = FactoryBot.create(:floating_ip)
login_as FactoryBot.create(:user)
login_as FactoryBot.create(:user_with_group)
end

subject do