Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abandon changes popup to tagging pages #6192

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Sep 16, 2019

Part of https://bugzilla.redhat.com/show_bug.cgi?id=1725927

Description

Tagging pages do not trigger the abandon changes popup, when leaving the page.

  • adds a condition which checks if values in tagging reducer are changed

Before

taggingbefore

After

taggingafter

@miq-bot add_label bug, ivanchuk/yes, tagging

@rvsia
Copy link
Contributor Author

rvsia commented Sep 16, 2019

@miq-bot add_label changelog/yes

@miq-bot add_reviewer @PanSpagetka

@miq-bot
Copy link
Member

miq-bot commented Sep 16, 2019

Checked commit rvsia@6dc7144 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Contributor

@PanSpagetka PanSpagetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works in UI 👍

@martinpovolny
Copy link
Member

Should we add some generic way how a page would hook in so that when navigations a custom page-specific check would get executed?

Rather than adding these things globally?

Thoughts, @Hyperkid123, @himdel, @rvsia ?

@martinpovolny martinpovolny self-assigned this Sep 18, 2019
@martinpovolny martinpovolny added this to the Sprint 121 Ending Sep 30, 2019 milestone Sep 18, 2019
@martinpovolny martinpovolny merged commit 7680efa into ManageIQ:master Sep 18, 2019
@himdel
Copy link
Contributor

himdel commented Sep 18, 2019

Should we add some generic way how a page would hook in so that when navigations a custom page-specific check would get executed?

I would wait and add it to the "screen" definition once we have frontend routing.
(Assuming there won't be a new kind of forms that would benefit from it now.)

@rvsia rvsia deleted the abandon-changes-tagging branch December 10, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants