Using class that includes both Job and Workflow templates #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed class name that was changed in ManageIQ#5925, previously made change was excluding Workflow Templates in UI. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1747589
|
Checked commit h-kataria@89f9ab2 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Sep 4, 2019
There was a problem hiding this comment.
Looks good to me. As stated in the BZ (want to include it here for reference) we want the parent class for ConfigurationWorkflow and ConfigurationScript for the External Automation Manager which leads us to ManageIQ::Providers::ExternalAutomationManager::ConfigurationScript
ManageIQ::Providers::AutomationManager::ConfigurationScript
ManageIQ::Providers::EmbeddedAutomationManager::ConfigurationScript
ManageIQ::Providers::EmbeddedAnsible::AutomationManager::ConfigurationWorkflow
ManageIQ::Providers::EmbeddedAnsible::AutomationManager::ConfigurationScript
ManageIQ::Providers::ExternalAutomationManager::ConfigurationScript
ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationWorkflow
ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationScript
simaishi
pushed a commit
that referenced
this pull request
Sep 4, 2019
…_templates Using class that includes both Job and Workflow templates (cherry picked from commit 35eaea4) https://bugzilla.redhat.com/show_bug.cgi?id=1747589
|
Ivanchuk backport details: |
|
@h-kataria can we get screenshots? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed class name that was changed in #5925, previously made change was excluding Workflow Templates in UI.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1747589
@tinaafitz pls review/verify.