Select active snapshot instead of the last one in the snapshots 🌳 #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@233d563 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot assign @h-kataria |
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
Select active snapshot instead of the last one in the snapshots 🌳 (cherry picked from commit 7de5d52) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805803
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the snapshots tree for VMs the last tree node is not always the active snapshot. Therefore, I had to alter the logic of the selected node evaluation to select the active snapshot instead of the last one. It's testing the node's text for the
(Active)suffix, which is not ideal. However, this is a fix to be backported and a more cleaner change would require a lot of risky changes in the codebase.@miq-bot add_reviewer @h-kataria
@miq-bot add_label bug, trees, ivanchuk/yes
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1745065