Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specs for Do not show custom buttons of children of GO/ServiceTemplate in toolbar #6090

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Specs for Do not show custom buttons of children of GO/ServiceTemplate in toolbar #6090

merged 1 commit into from
Sep 5, 2019

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Aug 23, 2019 •
edited
Loading

Add specs for #6063

@miq-bot add_label wip

@miq-bot miq-bot changed the title Do not show custom buttons of children of GO/ServiceTemplate in toolbar 2.0 [WIP] Do not show custom buttons of children of GO/ServiceTemplate in toolbar 2.0 Aug 23, 2019
@miq-bot miq-bot added the wip label Aug 23, 2019
@ZitaNemeckova ZitaNemeckova force-pushed the m branch 2 times, most recently from 5ca2f5a to 0e35f9c Compare August 23, 2019 13:51
@himdel himdel mentioned this pull request Sep 2, 2019
Merged
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label test

@miq-bot miq-bot added the test label Sep 5, 2019
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot
Copy link
Member

miq-bot commented Sep 5, 2019

Checked commit ZitaNemeckova@970bfd9 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@miq-bot miq-bot changed the title [WIP] Do not show custom buttons of children of GO/ServiceTemplate in toolbar 2.0 Do not show custom buttons of children of GO/ServiceTemplate in toolbar 2.0 Sep 5, 2019
@miq-bot miq-bot removed the wip label Sep 5, 2019
@ZitaNemeckova
Copy link
Contributor Author

@himdel here's the promised spec

@ZitaNemeckova ZitaNemeckova changed the title Do not show custom buttons of children of GO/ServiceTemplate in toolbar 2.0 Specs for Do not show custom buttons of children of GO/ServiceTemplate in toolbar Sep 5, 2019
@himdel himdel merged commit 217c34a into ManageIQ:master Sep 5, 2019
@himdel himdel self-assigned this Sep 5, 2019
@himdel himdel added this to the Sprint 120 Ending Sep 16, 2019 milestone Sep 5, 2019
@ZitaNemeckova ZitaNemeckova deleted the m branch September 5, 2019 12:20
simaishi pushed a commit that referenced this pull request Oct 31, 2019
@himdel @simaishi
Merge pull request #6090 from ZitaNemeckova/m
5cef9f8 
Specs for Do not show custom buttons of children of GO/ServiceTemplate in toolbar

(cherry picked from commit 217c34a)
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 5cef9f8a6e675df67d7b08a6503f289ce8bc9eb6
Author: Martin Hradil <[email protected]>
Date:   Thu Sep 5 14:16:23 2019 +0200

    Merge pull request #6090 from ZitaNemeckova/m
    
    Specs for Do not show custom buttons of children of GO/ServiceTemplate in toolbar
    
    (cherry picked from commit 217c34a78264857c05524ae44719e883cc628c19)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpovolny martinpovolny Awaiting requested review from martinpovolny

Assignees

@himdel himdel

Labels
ivanchuk/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZitaNemeckova @miq-bot @simaishi @himdel