Prevent login redirect with ?timeout during logout #6065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logging out via the Logout button, when there are multiple HTTP requests happening, the logout can cause API requests to fail with a 401 before the browser redirects to the login screen, causing the response handler to call redirectLogin, to redirec to the login screen with a "session timed out" message. We should not be claiming a timeout *during* logout, adding a check for that. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741283
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/32b4b1593752025d563d425617c16fb60865c813 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 21, 2019
Prevent login redirect with ?timeout during logout (cherry picked from commit 86fafd1) https://bugzilla.redhat.com/show_bug.cgi?id=1741283
|
Ivanchuk backport details: |
|
This is missing a similar fix for group change - #6325 |
This was referenced Oct 22, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging out via the Logout button,
when there are multiple HTTP requests happening,
the logout can cause API requests to fail with a 401 before the browser redirects to the login screen,
causing the response handler to call redirectLogin, to redirec to the login screen with a "session timed out" message.
We should not be claiming a timeout during logout, adding a check for that.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741283