Allow comparing Hosts and VMs/Instances displayed as a nested list #6044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstastna
force-pushed
the
Compare_Instances/Hosts_nested
branch
from
14b71e1 to
670ab7c
Compare
|
@miq-bot add_label bug, ivanchuk/yes, hammer/yes |
hstastna
force-pushed
the
Compare_Instances/Hosts_nested
branch
12 times, most recently
from
b7f4367 to
6654849
Compare
hstastna
changed the title
added 7 commits
August 27, 2019 15:51
hstastna
force-pushed
the
Compare_Instances/Hosts_nested
branch
from
6654849 to
fc99970
Compare
|
Checked commits hstastna/manageiq-ui-classic@467d061~...fc99970 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1741122
Related PR with more info: #5876
It was not possible to compare VMs/Instances/Hosts displayed in a nested list due to missing routes and/or missing
comparemiqmethod in some controllers. You clicked on "Compare Selected items" and nothing happened in the UI or error message about missing route appeared.Adding missing routes and
comparemiqcalls in appropriate controllers fixes the problem. I am also addingunless performed?to prevent multiple calls ofjavascript_flashmethod, for example in storage controller - this can happen for some operations because of this and this.Where I fixed comparing items:
a) Compute > Infra > Datastores > choose some Datastore > Hosts (Relationships)
b) Networks > Networks > choose some Network > Instances (Relationships)
c) Networks > Subnets > choose some Subnet > Instances (Relationships)
d) Storage > Block Storage > Volumes > choose some Volume > Instances (Relationships)
e) Networks > Network Routers > choose some Router > Instances (Relationships)
f) Compute > Infra > Resource Pools > choose some Pool > All/Direct VMs (Relationships)
g) Networks > Security Groups > choose some Group > Instances (Relationships)
Note:
Missing Cancel button to cancel Compare action will be added via another PR.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1733295 (fixed)
Before: (nothing happens in the UI)
After:
