Add Set Ownership to Key Pairs

[PanSpagetka]

Master version of #5967

Links [Optional]

#5967
https://bugzilla.redhat.com/show_bug.cgi?id=1589766
https://bugzilla.redhat.com/show_bug.cgi?id=1730066
ManageIQ/manageiq#19124

Screenshots

[PanSpagetka]

@h-kataria @lpichler

[h-kataria]

@PanSpagetka we will need to add this in the Product features as well.

[h-kataria]

@PanSpagetka one more thing, can we add ownership information on the summary screen as well. Same for the Hammer PR.

[PanSpagetka]

@miq-bot add_label pending core
ManageIQ/manageiq#19124

[andyvesel]

Tested on master. The PR partly solves the problem: Keypairs now have correct evm_owner_id and miq_group_id assigned.
I create keypair as an Admin. Then I set ownership to it to TestUser with TestGroup (and its role is a TestRole, where keypairs are visible). When I log in as a testuser, I don't see any kps
I tried to do it both with tenant mapping enabled and disabled.
So, the filtering still needs to be implemented on a backend side (in a different PR maybe).

[lpichler]

Tested on master. The PR partly solves the problem: Keypairs now have correct evm_owner_id and miq_group_id assigned.
I create keypair as an Admin. Then I set ownership to it to TestUser with TestGroup (and its role is a TestRole, where keypairs are visible). When I log in as a testuser, I don't see any kps
I tried to do it both with tenant mapping enabled and disabled.
So, the filtering still needs to be implemented on a backend side (in a different PR maybe).

@andyvesel thanks for testing we had similar result with @PanSpagetka
but we realised that user's role needs to have set up options"Access Restriction for Services, VMs, and Templates" to user or group.

if you have still this setup , can you try it ?

thanks!

[andyvesel]

@lpichler yes, I'll try it

[andyvesel]

Checked, LGTM 👍

[miq-bot]

Checked commits PanSpagetka/manageiq-ui-classic@5b6f8e7~...5accb14 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 4 offenses detected

app/helpers/application_helper/toolbar/auth_key_pair_cloud_center.rb

• ❗ - Line 16, Col 8 - Layout/AlignArray - Align the elements of an array literal if they span more than one line.
• ❗ - Line 17, Col 11 - Layout/IndentFirstArgument - Indent the first argument one step more than the start of the previous line.
• ❗ - Line 21, Col 60 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/auth_key_pair_clouds_center.rb

• ❗ - Line 24, Col 32 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

[lpichler]

thanks all ! LGTM & tested 👍 👍 so I am also confirming funcionality:

• if user belongs to root tenant (My Company) he will see all Key Pairs
• if user doesn't belongs to root tenant (My Company) he will see only Key Pairs with the user's tenant (Key Pairs can have tenant derived from assigned group in set ownership screen)

role's restriction :

• if user's role "Access Restriction for Services, VMs, and Templates" is set to Owned Group then user will see Key Pairs with this user's group(group is set in set ownership screen of Key Pairs)

• if user's role "Access Restriction for Services, VMs, and Templates" is set to Owned Group or User then user will see Key Pairs with this user's group or user (group or user is set in set ownership screen of Key Pairs)

[skateman]

I'm pretty sure there are collisions with #5863

[lpichler]

I'm pretty sure there are collisions with #5863

@PanSpagetka 🍝 got conflict and he did rebase.

[skateman]

Yeah, because rebasing always solves the problem 😆 the page is broken

[lpichler]

Yeah, because rebasing always solves the problem 😆 the page is broken
page is not broken in Ivanchuk just in master

@simaishi

[PanSpagetka]

ManageIQ/manageiq-api#650 this PR solves the problem

[simaishi]

Ivanchuk backport details:

$ git log -1
commit f0b1b500f1a029429b58716af3cf64a31bc79fa6
Author: Harpreet Kataria <[email protected]>
Date:   Tue Aug 13 10:25:55 2019 -0400

    Merge pull request #5973 from PanSpagetka/add-ownership-keypair
    
    Add Set Ownership to Key Pairs
    
    (cherry picked from commit 5692b46ca8720ede8deb67c343f92aba39bd3456)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1589766
    https://bugzilla.redhat.com/show_bug.cgi?id=1730066

[simaishi]

Backported to Hammer via #5967