Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button sets order in tree #5914

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Fix button sets order in tree #5914

merged 1 commit into from
Aug 1, 2019

Conversation

ZitaNemeckova
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1665031

Go to Automation -> Automate -> Generic Objects -> click Actions in a tree-> Add some custom button sets that start with UpperCase letter and some that start with LowerCase letter -> see different order in tree and GTL

Look at annabelle custom button set
Before:
Screenshot 2019-07-31 at 14 27 43
After:
Screenshot 2019-07-31 at 14 26 50

@romanblanco please have a look, thanks

@miq-bot add_label hammer/yes, ivanchuc/yes, bug, generic objects

@miq-bot
Copy link
Member

miq-bot commented Jul 31, 2019

@ZitaNemeckova Cannot apply the following label because they are not recognized: ivanchuc/yes

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label ivanchuk/yes

romanblanco
romanblanco approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works 👍

@mzazrivec
Copy link
Contributor

@ZitaNemeckova Can you please fix the rubocop warning above? Thanks.

@ZitaNemeckova ZitaNemeckova force-pushed the GOD_button_sets_order branch from 061b8d3 to e94bbcf Compare August 1, 2019 09:29
@ZitaNemeckova
Copy link
Contributor Author

@mzazrivec Fixed :)

@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2019

Checked commit ZitaNemeckova@e94bbcf with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Aug 1, 2019
@mzazrivec mzazrivec added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 1, 2019
@mzazrivec mzazrivec merged commit 40020b0 into ManageIQ:master Aug 1, 2019
simaishi pushed a commit that referenced this pull request Aug 1, 2019
@mzazrivec @simaishi
Merge pull request #5914 from ZitaNemeckova/GOD_button_sets_order
3fc0f62 
Fix button sets order in tree

(cherry picked from commit 40020b0)

https://bugzilla.redhat.com/show_bug.cgi?id=1665031
@simaishi
Copy link
Contributor

simaishi commented Aug 1, 2019

Ivanchuk backport details:

$ git log -1
commit 3fc0f6243197345a0981d3fc69406286599410cb
Author: Milan Zázrivec <[email protected]>
Date:   Thu Aug 1 11:54:12 2019 +0200

    Merge pull request #5914 from ZitaNemeckova/GOD_button_sets_order
    
    Fix button sets order in tree
    
    (cherry picked from commit 40020b0c39bd630a00a3241fc1fdaa6e021a0b61)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1665031

@ZitaNemeckova ZitaNemeckova deleted the GOD_button_sets_order branch September 18, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanblanco romanblanco romanblanco approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug generic objects ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZitaNemeckova @miq-bot @mzazrivec @simaishi @romanblanco @Fryguy