Clear modal after Applying advanced search

[bmclaughlin]

When applying a boolean advanced search the modal is not hidden resulting in an unclickable screen.

Reproduced via:
Compute - Cloud - Instances - All Instances
Advanced search consisting of: Field: Instance : Active = "true"

@miq-bot add_labels bug, compute/cloud

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1725838

[bmclaughlin]

@himdel Is there a better place to hide the modal here? Per #5875 this looks like another instance of needing to update replace_right_cell to me.

[miq-bot]

Checked commit bmclaughlin@7c7a4de with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/views/layouts/_adv_search_footer.html.haml

• ⚠️ - Line 30 - Line is too long. [161/160]

[himdel]

Oh, interesting..
Yeah, looks like this is happening because we never actually hide the modal, only replace the div itself so that the modal is hidden, which doesn't affect the backdrop.

So yeah, I think your fix works just fine 👍

(Just starting to wonder whether we should extend ExplorerPresenter to support hiding modals explicitly, since this is needed for more than just quick search, but that's probably a larger refactoring.)

[simaishi]

Ivanchuk backport details:

$ git log -1
commit 65a4963d7d67134936b4a02cb1d88a82f9f6c74d
Author: Martin Hradil <[email protected]>
Date:   Wed Jul 31 12:59:49 2019 +0200

    Merge pull request #5909 from bmclaughlin/hide-advanced-search-modal
    
    Clear modal after Applying advanced search
    
    (cherry picked from commit 96866070a170a0ae04fbf3c8a4a46628fea6ef8a)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1725838

[hstastna]

Just a note that we need to backport this PR to hammer to fix the bug https://bugzilla.redhat.com/show_bug.cgi?id=1811145. Thanks.

[simaishi]

Hammer backport details:

$ git log -1
commit 45b89d3b03e28969f6345482a952bdba080a55ab
Author: Martin Hradil <[email protected]>
Date:   Wed Jul 31 12:59:49 2019 +0200

    Merge pull request #5909 from bmclaughlin/hide-advanced-search-modal

    Clear modal after Applying advanced search

    (cherry picked from commit 96866070a170a0ae04fbf3c8a4a46628fea6ef8a)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1811145