Fixed issues with 'Back' button on right size screen #5878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am okay with the changes, but I think we need a test for it. |
hstastna
approved these changes
Jul 26, 2019
h-kataria
force-pushed
the
vm_right_size_back_button_fix
branch
from
3cc063c to
738562f
Compare
skateman
suggested changes
Jul 29, 2019
| describe "#right_size" do | ||
| before do | ||
| stub_user(:features => :all) | ||
| @vm = FactoryBot.create(:vm_vmware) |
There was a problem hiding this comment.
Instance variables in rspec can tamper with other specs, please use this outside the before block.
Suggested change
| @vm = FactoryBot.create(:vm_vmware) | |
| let!(:vm) { FactoryBot.create(:vm_vmware) } |
Multiple issues fixed with back button on non-explorer version of VM Right Size recommendations screen - fixed a typo it should be `@record.id` - fixed call to javascript_prologue, method does not expect argument - added code to redirect back to previous screen when back button is pressed Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1733207
h-kataria
force-pushed
the
vm_right_size_back_button_fix
branch
from
738562f to
3389bdd
Compare
|
Checked commit h-kataria@3389bdd with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jul 30, 2019
Fixed issues with 'Back' button on right size screen (cherry picked from commit a459a48) https://bugzilla.redhat.com/show_bug.cgi?id=1733207
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple issues fixed with back button on non-explorer version of VM Right Size recommendations screen
@record.idFixes https://bugzilla.redhat.com/show_bug.cgi?id=1733207
Note: This is only an issue when drilling down to list of VMs thru relationships and selecting a VM from a list view to view it's right size recommendations.
Please review @hstastna @skateman