Fixed container provider custom button dialog redirect. #5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label bug |
|
Checked commit Hyperkid123@15f7d08 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jul 25, 2019
…direct Fixed container provider custom button dialog redirect. (cherry picked from commit 7059285) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1732489
|
Ivanchuk backport details: |
|
Backporting to 54 when /ExtManagementSystem/
55 api_collection_name = "providers"
56 <<<<<<< HEAD
57 cancel_endpoint = obj.class.name.demodulize == "CloudManager" ? "/ems_cloud" : "/ems_infra"
58 =======
59 class_name = obj.class.name.demodulize
60 cancel_endpoint =
61 case class_name
62 when "CloudManager"
63 "/ems_cloud"
64 when "NetworkManager"
65 "/ems_networks"
66 when "CinderManager"
67 "/ems_block_storage"
68 when "SwiftManager"
69 "/ems_object_storage"
70 when "ContainerManager"
71 "/ems_container/#{obj.id}"
72 else
73 "/ems_infra"
74 end
75 >>>>>>> 705928522... Merge pull request #5869 from Hyperkid123/fix-emx-container-dialog-redirect |
|
@Hyperkid123 ^ Just want to make sure you're aware of this... |
|
@simaishi oh sorry i did not get notified (or i missed it) |
simaishi
pushed a commit
that referenced
this pull request
Aug 16, 2019
…direct Fixed container provider custom button dialog redirect. (cherry picked from commit 7059285) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1733376
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1732489
After submit/cancel container provider dialog triggered with custom button, user was redirected to infra provider screen. He should have been redirected back from where the dialog was open (container provider detail)
Cause
ContainerManagerclassChanges
ContainerManagerclass indetermine_api_endpointsmethod.