Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select the features tree items when 'everything' is allowed #5858

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Select the features tree items when 'everything' is allowed #5858

merged 1 commit into from
Jul 24, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Jul 24, 2019 •
edited
Loading

This is a regression possibly caused by the refactoring of the rbac features tree. Basically when all features are checked, there's no list of features, instead we use everything and the checked state of the nodes was not universal for this meta-feature.

@miq-bot add_label bug, ivanchuk/yes, hammer/no, trees, rbac
@miq-bot add_reviewer @ZitaNemeckova

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1732576

@miq-bot miq-bot requested a review from ZitaNemeckova July 24, 2019 09:30
@miq-bot miq-bot added the wip label Jul 24, 2019
@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2019

Checked commit skateman@f9d562a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

ZitaNemeckova
ZitaNemeckova approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
Screenshot 2019-07-24 at 14 34 07

After:
Screenshot 2019-07-24 at 14 32 24

LGTM 👍

@skateman skateman changed the title [WIP] Select the features tree items when 'everything' is allowed Select the features tree items when 'everything' is allowed Jul 24, 2019
@skateman
Copy link
Member Author

@miq-bot assign @h-kataria

@miq-bot miq-bot removed the wip label Jul 24, 2019
@h-kataria h-kataria added this to the Sprint 117 Ending Aug 5, 2019 milestone Jul 24, 2019
@h-kataria h-kataria merged commit d5f9004 into ManageIQ:master Jul 24, 2019
@skateman skateman deleted the features-tree-select branch July 24, 2019 14:05
simaishi pushed a commit that referenced this pull request Jul 25, 2019
@h-kataria @simaishi
Merge pull request #5858 from skateman/features-tree-select
0f82e56 
Select the features tree items when 'everything' is allowed

(cherry picked from commit d5f9004)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1732576
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 0f82e567580e6e531c63cff08a5ac7e64f1bea8e
Author: Harpreet Kataria <[email protected]>
Date:   Wed Jul 24 10:03:01 2019 -0400

    Merge pull request #5858 from skateman/features-tree-select
    
    Select the features tree items when 'everything' is allowed
    
    (cherry picked from commit d5f9004ddf93c6f58cd15aecece38563e4f30fa6)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1732576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZitaNemeckova ZitaNemeckova ZitaNemeckova approved these changes

Assignees

@h-kataria h-kataria

Labels
bug hammer/no ivanchuk/backported rbac trees
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skateman @miq-bot @simaishi @ZitaNemeckova @h-kataria